Dlaczego po dodaniu adnotacji @Mock wywala mi java.lang.NullPointerException

0

Cześć. Możecie mi powiedzieć, dlaczego po dodaniu adnotacji @mock wywala mi NPE?

W ten sposób działa, test przechodzi:

@Test
    void createNewCustomer() throws SQLException {
        CarRentalStorage carRentalStorageMock = mock(CarRentalStorage.class);
 
        CarRentalOptions carRentalOptions = new CarRentalOptions(carRentalStorageMock);
        Client client = new Client();
 
        carRentalOptions.createNewCustomer(client);
 
        List<Client> listOfClients = new ArrayList<Client>();
        listOfClients.add(client);
 
        verify(carRentalStorageMock).addClient(client);
 
        when(carRentalStorageMock.getAllCustomers()).thenReturn(listOfClients);
 
        assertEquals(1, listOfClients.size());
    }

Jeżeli zrobie coś takiego, to wywala mi NPE.

@RunWith(MockitoJUnitRunner.class)
class CarRentalOptionsTest {

    @Mock
    CarRentalStorage carRentalStorageMock;
    @Test
    void createNewCustomer() throws SQLException {
        //CarRentalStorage carRentalStorageMock = mock(CarRentalStorage.class);

        CarRentalOptions carRentalOptions = new CarRentalOptions(carRentalStorageMock);
        Client client = new Client();

        carRentalOptions.createNewCustomer(client);

        List<Client> listOfClients = new ArrayList<Client>();
        listOfClients.add(client);

        verify(carRentalStorageMock).addClient(client);

        when(carRentalStorageMock.getAllCustomers()).thenReturn(listOfClients);

        assertEquals(1, listOfClients.size());
    }
}

Dodam, ze kierowałem się tym i tam wszystko działa:

Testuję tę metodę z CarRentalOptions

void createNewCustomer(Client client) throws SQLException {
        storage.addClient(client);
    }
1

dodaj metode z adnotacją @Before i tam Masz

@Before
	public void setUp(){
		MockitoAnnotations.initMocks(this);
	}
0
Black007 napisał(a):

dodaj metode z adnotacją @Before i tam Masz

@Before
	public void setUp(){
		MockitoAnnotations.initMocks(this);
	}
 @Mock
    CarRentalStorage carRentalStorageMock;


    @Before
    public void setUp(){
        MockitoAnnotations.initMocks(this);
    }
    
    @Test
    void createNewCustomer() throws SQLException {
        // carRentalStorageMock = mock(CarRentalStorage.class);
        CarRentalOptions carRentalOptions = new CarRentalOptions(carRentalStorageMock);
        Client client = new Client();

        List<Client> listOfClients = new ArrayList<Client>();
        listOfClients.add(client);
        when(carRentalStorageMock.getAllCustomers()).thenReturn(listOfClients);

        carRentalOptions.createNewCustomer(client);

        verify(carRentalStorageMock).addClient(client);


        assertEquals(1, listOfClients.size());
    
}
java.lang.NullPointerException
	at CarRental.CarRentalOptionsTest.createNewCustomer(CarRentalOptionsTest.java:41)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
	at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:515)
	at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:115)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$6(TestMethodTestDescriptor.java:170)
	at org.junit.jupiter.engine.execution.ThrowableCollector.execute(ThrowableCollector.java:40)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:166)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:113)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:58)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:134)
	at org.junit.platform.engine.support.hierarchical.SingleTestExecutor.executeSafely(SingleTestExecutor.java:66)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:128)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:109)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1378)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.SingleTestExecutor.executeSafely(SingleTestExecutor.java:66)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:128)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:109)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1378)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.SingleTestExecutor.executeSafely(SingleTestExecutor.java:66)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:128)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:109)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:32)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:49)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:47)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:184)
	at org.junit.platform.launcher.core.DefaultLauncher.lambda$execute$5(DefaultLauncher.java:152)
	at org.junit.platform.launcher.core.DefaultLauncher.withInterceptedStreams(DefaultLauncher.java:166)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:145)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:92)
	at com.intellij.junit5.JUnit5IdeaTestRunner.startRunnerWithArgs(JUnit5IdeaTestRunner.java:74)
	at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)

1

41 linia, to która w twoim pliku testu?

1

Co robi ta metoda:

carRentalStorageMock.getAllCustomers()

Bo w logu widzę, że tam jakiś foreach leci

1

Ten assertEquals(1, listOfClients.size()); będzie zawsze true - bo testujesz coś, co ustawiasz

0
Black007 napisał(a):

Co robi ta metoda:

carRentalStorageMock.getAllCustomers()

Bo w logu widzę, że tam jakiś foreach leci

interface CarRentalStorage
List<Client> getAllCustomers() throws SQLException;
Jeżeli zagłębić się bardziej:

@Override
    public List<Client> getAllCustomers() throws SQLException {
        List<Client> listOfClients = new ArrayList<Client>();

        String sql = "SELECT * FROM `client`";
        result = statement.executeQuery(sql);

        while (result.next()) {
            Client client = new Client();
            client.setName(result.getString("namee"));
            client.setSurname(result.getString("surname"));
            client.setStreet(result.getString("street"));
            client.setPeselNumber(result.getLong("peselNumber"));
            client.setRentDate(result.getString("rentDate"));
            client.setCity(result.getString("city"));
            client.setHouseNumber(result.getInt("houseNumber"));
            client.setClientNumber(result.getInt("clientNumber"));

            listOfClients.add(client);
        }

        return listOfClients;
    }
1

Ok ściągnąłem to repo, jestem na branchu correction.
Dobrze, że zacząłeś używać ide i do tego intelij - to się chwali.
Przede wszystkim trzeba zrobić porządek z katalogami zamiast katalogów db i CartRenatl przenieś je do pakietów: zgodnie z tym: https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html

1 użytkowników online, w tym zalogowanych: 0, gości: 1